Repository navigation
Add "How this was made" disclosure and AI labels - #9749
caetano-dev wants to merge 22 commits into
Conversation
github-actions
Bot
added
the
PR: waiting for review
There was a problem hiding this comment.
-
https://github.com/FreeTubeApp/FreeTube/pull/9749/changes#diff-4eaadcc25bfbd7ab1ba912e36d5e1bcbab346cab59546a970df7546d5fb7a145R895 doesnt seem to be used anywhere but if it was then it begs the question why only translate this but not captured with the camera and other things that can be listed there?
-
I dont think adding the options to hide these is necessary so i would opt for removing those options
-
When hovering the AI label i noticed that the tooltip is reusing the wording of the AI description from how its made. Use whats provided in the aria-label of the AI label instead
-
Please put the How this was made section above the license like yt
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: changes requested
and removed
PR: waiting for review
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
absidue
added
PR: changes requested
and removed
PR: waiting for review
|
Changes applied. |
|
Blocked until youtube.js 18.1.0 is released LuanRT/YouTube.js#1240 |
|
#9858 merged! |
|
New version integrated and now it shows the attribution text Edit: There seems to be an issue with the text. I am working on a fix. Sorry for the ping Edit 2: Fixed. |
absidue
added
PR: waiting for review
PikachuEXE
left a comment
PikachuEXE
left a comment
There was a problem hiding this comment.
I think it's better to have a divider (style to be decided) otherwise not very obvious it's extra info
5 participants
Pull Request Type
Related issue
closes #9746
Description
This PR adds a label for AI content in the watch page + "How this was made" disclosures in the description.
The label only shows up if the video has AI. The automatic dubbing and "Captured with a camera" videos show the disclosure only.
Screenshots
Testing
Open https://www.youtube.com/watch?v=gfjgRHtDa38
Open https://youtu.be/7RogQiih3M8
Open https://youtu.be/BxunALc8r18
and see that the label + description shows up for the AI video. For the others, there should be the description only.
Desktop
Additional context
Initially, I only planned to add the AI tags, but since I was already halfway through adding the other descriptions, I decided to implement both.